tag:blogger.com,1999:blog-6950833531562942289.post6560223071145622566..comments2024-03-25T03:36:48.099-07:00Comments on C0DE517E: CommandoDEADC0DEhttp://www.blogger.com/profile/01477408942876127202noreply@blogger.comBlogger8125tag:blogger.com,1999:blog-6950833531562942289.post-79890383650542616152008-07-29T20:14:00.000-07:002008-07-29T20:14:00.000-07:00yours truly: the problem is deeper than just apply...yours truly: the problem is deeper than just applying the commando... the thing I hate is writing code that I don't really understand, you know, when you copy&paste&modify... Your code seems to be ok, but maybe you're copying an ad-hoc hack that has been done (and not documented), replicating it in another place where it does not belong, or in general, you're writing suboptimal code... Code reviews are a great way of avoiding those risks, if there's at least someone that knows what that subsystem does...<BR/><BR/>diego: unfortunately, Milani is not with me anymore. I know that I shouldn't talk of Him, but now He is so far away... I've even lost his sacred image, as I lost my wallet :| The good thing is that here his allmighty powers are not needed, as people usually fix stuff in the proper way, and there's always at least someone that knows what to do... It's true that it requires 10 engineers instead of 1, but eventually it turns out not to be that bad, because the code is more readable by mere humans, and it does not take one week to do a menu page...DEADC0DEhttps://www.blogger.com/profile/01477408942876127202noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-77880694808600152212008-07-29T16:09:00.000-07:002008-07-29T16:09:00.000-07:00NO ONE TALKS ABOUT MILANI.Paolo is so powerful tha...NO ONE TALKS ABOUT MILANI.<BR/>Paolo is so powerful that just a picture of him can resurrect a Xenon with the ring of death to life and run the code with fixes no one coded ever. If you think i am joking ask the author of the post the quickest a best way to fix bug without codeAnonymoushttps://www.blogger.com/profile/05045997407274494903noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-40122436199744195322008-07-29T15:32:00.000-07:002008-07-29T15:32:00.000-07:00lol, good post indeed. Unfortunately my experience...lol, good post indeed. <BR/><BR/>Unfortunately my experience is that code that has been half comandoed (i.e. comando pattern with a hint of strive to preserve encapsulation and sound engineering principles) almost never gets reworked. By the time we are able to fix it the next firefighting incident has occured and another commando is initiated... and so on.<BR/><BR/>What is worse is that comando code usually results in some subtle side effect in a different subsystem you wouldn't spot unless you have some serious testing process in place - especially for rendering.<BR/><BR/>Even worse, you make a comando version of a feature, artists get used it, you get time to do it properly but now you have to support the "baggage" because there are assets depending on it and half of the time you can't touch it. <BR/><BR/>And you need to learn to switch off... which incidently I need to learn to do as well :)FieldsOfCarphttps://www.blogger.com/profile/17720373803891645622noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-73143733078011200322008-07-29T13:41:00.000-07:002008-07-29T13:41:00.000-07:00No offense taken, I was in fact just saying that y...No offense taken, I was in fact just saying that you're right when you say that those things in my code are bad, there is a lot of bad code and even bad design in that project.<BR/><BR/>Unfortunately you have the burden of fixing all that... and even if you can remove the broken code that I did, I don't think you'll ever have time to fix the design, that unfortunately was not well done from the beginning, I did not have the idea of the domain, and the discussions with David underestimated a lot of problems than later appeared evident.<BR/><BR/>I consider that stuff as a prototype where we experimented with a lot of ideas, I learned a new programming language, for a thing done in two weeks was really good, then we should have deleted most of it and done it for real, instead of using that as our final solution, just patching more and more stuff into it...DEADC0DEhttps://www.blogger.com/profile/01477408942876127202noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-22533885773700492592008-07-29T11:28:00.000-07:002008-07-29T11:28:00.000-07:00I am not judging your coding skills, I am not even...I am not judging your coding skills, I am not even a full time programmer and if I were I would never be even half as good as you or Milani. I mentioned that piece of code more as a joke than a problem – Seeing it for the first time I got the impression that you were just showing off: “Look everyone, I’m clever and I have no problems writing in such (overly) complex way. Let David suffer debugging it.” ;)<BR/>To make it clear, although I disagree with some of your ideas (from those that I can understand), I believe you are a very competent programmer.Unknownhttps://www.blogger.com/profile/00325129436405380404noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-54889292677870309242008-07-29T10:05:00.000-07:002008-07-29T10:05:00.000-07:00remigiusz: well your idea of my code is biased, as...remigiusz: well your idea of my code is biased, as that project is not the best example of my skills. <BR/><BR/>I started it knowing nothing of C# (and you should be happy that I've introduced that language into the company!) so some stuff is... suboptimal, while the later code is better.<BR/><BR/>For example, the stuff you're talking about, was for me mostly an experiment, to see if you could do functional programming in C#. I did not even realize that there was already a "map" function in the standard containers...<BR/><BR/>But anyway, yes, in general it is much nicer to use functional primitives instead of loops :PDEADC0DEhttps://www.blogger.com/profile/01477408942876127202noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-82650399585023693632008-07-29T04:16:00.000-07:002008-07-29T04:16:00.000-07:00After arriving here it took me less than a month t...After arriving here it took me less than a month to realize that Paolo is some kind of a Wunderwaffe;) <BR/>But don't be so modest, you also seem to be a fan of obscurity in code;) Or is only me who thinks that passing code around in delegates (where a simple loop will do) is confusing? :)Unknownhttps://www.blogger.com/profile/00325129436405380404noreply@blogger.comtag:blogger.com,1999:blog-6950833531562942289.post-75249285233352428672008-07-29T01:24:00.000-07:002008-07-29T01:24:00.000-07:00arf funny post !arf funny post !Victorushttps://www.blogger.com/profile/05485110187815395099noreply@blogger.com